Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dart support #2236

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add dart support #2236

merged 2 commits into from
Nov 26, 2024

Conversation

malkoG
Copy link
Contributor

@malkoG malkoG commented Nov 4, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2024

CLA assistant check
All committers have signed the CLA.

@paul-gauthier
Copy link
Collaborator

Thanks, where did you source this scm file?

@malkoG
Copy link
Contributor Author

malkoG commented Nov 4, 2024

@albemala
Copy link

I’d be interested in having dart and flutter supported in Aider. @paul-gauthier is there anything I can do to help having this PR merged?

@paul-gauthier paul-gauthier merged commit 6b9d534 into Aider-AI:main Nov 26, 2024
1 check passed
@paul-gauthier
Copy link
Collaborator

Thanks for pushing this forward, apologies I was so slow to merge.

@albemala
Copy link

No worries at all @paul-gauthier , thank you for your great work on Aider! As a side note, will this change be enough to support mapping dart and flutter projects?

@paul-gauthier
Copy link
Collaborator

It should. You can do aider --show-repo-map in your repo and see.

@albemala
Copy link

awesome, thank you

@paul-gauthier
Copy link
Collaborator

@malkoG did you test this PR before submitting it?

@malkoG
Copy link
Contributor Author

malkoG commented Nov 27, 2024

Sorry, i didn't. I only tried on treesitter-dart repository.

@nkeilar
Copy link

nkeilar commented Nov 29, 2024

We tested and its just outputting a list of dart filenames in the repomap... should there be more introspection going on than that... the filenames alone don't provide much context really... Maybe another library is needed as well? @malkoG

@paul-gauthier
Copy link
Collaborator

This pr did not add support for dart. It has been rolled back in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants